Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add missing config argument to _get_or_render_metadata #28461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d70-t
Copy link

@d70-t d70-t commented Dec 5, 2024

Within .ci_support/compute_build_graph.py,_get_or_render_metadata is called from two sites, but when called from _buildable, the config argument was not passed along. Apparently, it's not possible to build multiple interdependent noarch: python packages in one PR without this config argument, but the build seems to work when applying the change as proposed in this PR.

I have to admit, that I'm new to conda-forge and didn't yet understand what exactly is passed along in this config argument, but I guessed that the python_min variable would be part of it.
I also have to admit, that I don't know if a PR to this repo would actually be the right way to fix this issue, I'd be glad for some guidelines if there'd be a better place.

Fixes #28445

_get_or_render_metadata is called from two sites, but when called from
_buildable, the config argument was not passed along.

Fixes conda-forge#28445
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • .ci_support/compute_build_graph.py:
    • lints:
      • Do not edit files outside of the recipes/ directory.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR () and found it was in an excellent condition.

@d70-t
Copy link
Author

d70-t commented Dec 5, 2024

The linter rightfully complains about me changing something else than a receipe, but I guess that was intended. As I'm new to conda-forge, I'd hope that I interpreted the PR instructions correctly when asking:

@conda-forge/help-python, ready for review!

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Build fails with python_min is undefined in PRs with multiple packages
3 participants