Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlines core #28863

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Outlines core #28863

wants to merge 5 commits into from

Conversation

hadim
Copy link
Member

@hadim hadim commented Jan 17, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 17, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12836447599. Examine the logs at this URL for more detail.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • recipes/example-v1/recipe.yaml:

    • lints:
      • Do not edit or delete example recipes in recipes/example/ or recipe/example-v1/.
  • recipes/example/meta.yaml:

    • lints:
      • Do not edit or delete example recipes in recipes/example/ or recipe/example-v1/.
  • recipes/example-v1/README.md:

    • lints:
      • Please put your recipe in its own directory in the recipes/ directory as recipe/<name of feedstock>/<your recipe file>.yaml.
  • .ci_support/osx_arm64.yaml:

    • lints:
      • Do not edit files outside of the recipes/ directory.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/outlines-core/recipe.yaml) and found it was in an excellent condition.

@hadim hadim mentioned this pull request Jan 17, 2025
10 tasks
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 17, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12836611789. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/outlines-core/recipe.yaml) and found it was in an excellent condition.

@hadim hadim marked this pull request as ready for review January 17, 2025 21:22
@hadim
Copy link
Member Author

hadim commented Jan 17, 2025

@conda-forge/help-rust @conda-forge/staged-recipes ready for review

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good to me. It uses cargo-bundle-licenses and supports build_platform != target_platform.

Strange that this PR received the R GitHub label though.

I am willing to comaintain this feedstock, but I'm happy to be added after feedstock creation for the purposes of expediting review by keeping the CI green.

@maresb maresb mentioned this pull request Jan 18, 2025
10 tasks
recipes/outlines-core/recipe.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants