Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary fmt Makefile target #2246

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove unnecessary fmt Makefile target #2246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include Makefile.defaults

.PHONY: check fmt
.PHONY: check

SHELL = bash -o pipefail

Expand All @@ -24,11 +24,7 @@ help: ## Display this help.

## Run formatters and linters against the code.
.PHONY: check
check: fmt golangci-lint shellcheck tidy-check govulncheck packer-check terraform-check

.PHONY: fmt
fmt: ## Run go fmt against code.
find . -name '*.go' -print0 | xargs -0 gofmt -l -s -w
check: golangci-lint shellcheck tidy-check govulncheck packer-check terraform-check

.PHONY: shellcheck
shellcheck: ## Run shellcheck against shell scripts.
Expand Down