ibmcloud: Fixes and improvements to ROKS demo instructions #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhorsman
force-pushed
the
roks-ibmcloud
branch
from
0639cb1 to
648bda3
Compare
|
There seemed to be an issue with the rebase such that there was a trailing merge commit that was empty, but causing the commit check to fail, so I took the liberty to tidy it up. I hope that's okay. |
stevenhorsman
approved these changes
Jan 17, 2025
|
I believe the e2e test is failing as it needs rebasing as it's the sealed secret test that we fixed on Friday |
1. Changed the instructions to use latest ghcr.io podvm image. 2. Fixed Makefile to download correct OS version of cmctl. 3. Other small corrections and improvements to the doc. Signed-off-by: Frank Budinsky <[email protected]>
frankbu
force-pushed
the
roks-ibmcloud
branch
from
648bda3 to
64375e0
Compare
mkulke
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the instructions to use latest ghcr.io podvm image.
Fixed Makefile to download correct OS version of cmctl.
Other small corrections and improvements to the doc.