Add feature pages for the REST API (resources and attestation) #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frolicking-manatee-96c0c8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pawelpros
reviewed
Jan 8, 2025
|
|
||
| For example, you can run this command from your container. | ||
| ```bash | ||
| curl http://127.0.0.1:8006/cdh/resource/default/key/1 |
There was a problem hiding this comment.
Can You add additional information about how to create such resource i.e.:
https://github.com/confidential-containers/trustee/blob/main/kbs/docs/resource_storage_backend.md
and information about corresponding config section:
[[plugins]]
name = "resource"
type = "LocalFs"
dir_path = "/opt/confidential-containers/kbs/repository"There was a problem hiding this comment.
Setting up resources is out of scope for individual features. The attestation section should describe how to do this rather than repeating it for every feature that relies on attestation.
mythi
reviewed
Jan 17, 2025
mythi
reviewed
Jan 17, 2025
Description of how to get resources from containers Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Describe how to enable and use the ASR to get attestation evidence. Also add a section about the evidence factory considerations. That is too complex a topic to get to the bottom of here, and we don't actually have a great solution to it until init-data support lands, but hopefully the note is useful. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
fitzthum
force-pushed
the
asr-features
branch
from
1ca6673 to
0a07970
Compare
mythi
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit tricky to address the evidence factory stuff, but hopefully the note there is useful.