install: several fixes to avoid containerd config file corruption #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it might happen that someone else is also modifying containerd configuration at the same time. This patch ensures our modification is atomic and only applied when the source file is not changed. In case it fails to update the file in 10 iterations it fails. Signed-off-by: Lukáš Doktor <[email protected]>
containerd fails to start when import is missing. Let's first remove the import and only when it's gone remove the drop-in nydus configuration. Signed-off-by: Lukáš Doktor <[email protected]>
the install pod can fail and be re-scheduled. Modify the containerd setup to allow re-execution without breaking the setup. Fixes: confidential-containers#481 Signed-off-by: Lukáš Doktor <[email protected]>
Signed-off-by: Lukáš Doktor <[email protected]>
the labeling itself as well as all the following jobs require functional node. Let's wait for the node to be up and running before labeling it. Signed-off-by: Lukáš Doktor <[email protected]>
I don't really have a preference. This one is less intrusive but I only tested it briefly. It should decrease the probability of hitting the issue, but it is only a workaround, while the #483 is a proper fix. On the other hand #483 contains intrusive changes (changing names of labels) which might not be a good idea this early before a release (on the other hand I have tested that one a lot and it seems to work well) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corruption seems to be mainly caused by double-execution of the pre-reqs setup. This part should avoid the corruption but it still might collide with kata-deploy as the operator currently uses the same label to start cleanup and to detect the cleanup is done. This should be handled separately later...
Fixes #481