Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Coolify docker installer fail on Fedora 41 with DNF5 #4289

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

NexiaMoe
Copy link

Changes

  • fix: Docker installation failure on Fedora 41 with dnf5
3. Check Docker Installation. 
 - Docker is not installed. Installing Docker. It may take a while.
 - Until then, here's a joke for you:

# Executing docker install script, commit: e5543d473431b782227f8908005543bb4389b8de
+ sh -c 'dnf install -y -q dnf-plugins-core'
Package "dnf-plugins-core-4.9.0-1.fc41.noarch" is already installed.

Nothing to do.
+ sh -c 'dnf config-manager --add-repo https://download.docker.com/linux/fedora/docker-ce.repo'
Unknown argument "--add-repo" for command "config-manager". Add "--help" for more information about the arguments.

Based on my observation, it fails with the Rancher Docker installer. I added a new case for Fedora to handle Docker installation. The script checks for the presence of dnf5 and uses the updated addrepo options if available; otherwise, it falls back to using dnf.

Issues

  • fix #

@peaklabs-dev
Copy link
Member

Thank you for the PR 💜.

@peaklabs-dev peaklabs-dev merged commit 36fd0b1 into coollabsio:next Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants