refactor: fix Bitbucket preview deployments by switching to PR update events #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4.0.0-beta.390
…y replacing repo:push with pullrequest:updated in bitbucket webhook hander Bitbucket's repo:push webhook doesn't provide the destination branch name in new commits, which prevents Coolify from finding the correct application to update preview deployments. By switching to pullrequest:updated and only processing updates due to new commits, we can reliably get the correct branch name that matches the Coolify application, ensuring preview deployments are properly updated. - Remove repo:push event handling in favor of pullrequest:updated - Add check to ignore PR updates not related to new commits - Update handled_events collection to reflect new webhook strategy Closes coollabsio#2793
…event as the rest of x_bitbucket_event
IARayan
changed the title
…re the updated is not due to a pullrequest By introducing the pullrequest:update we are able to handle preview deployments updates for a new commit, however if the commit was done to the branch that matches the application branch directly and not via a pull request it would have failed since repo:push is no longer handled, this change ensures that both cases are handled correctly and Coolify's current state is satisfactory and backward compatible
|
Implementation currently lacks a way of determining if the event is fired due to a PR update that was fired due to new commits as we are not story commit hashes at least to compare, looking for a workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
repo:pushwebhook handling withpullrequest:updatedeventhandled_eventscollection to removerepo:pushand addpullrequest:updatedIssues