Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Msys2 package to installation page #900

Merged

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Feb 11, 2025

Note: shards is not yet available in the MSYS2 repository.

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for crystal-website ready!

Name Link
🔨 Latest commit 08e9acd
🔍 Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/67ace0ffc900020008ec9293
😎 Deploy Preview https://deploy-preview-900--crystal-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@HertzDevil HertzDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if listing only the MINGW64 package is a good idea, especially since UCRT64 is more common nowadays

_data/packages.yaml Outdated Show resolved Hide resolved
@straight-shoota
Copy link
Member Author

I'm happy to follow your lead 👍

Co-authored-by: Quinton Miller <[email protected]>
@straight-shoota
Copy link
Member Author

I'm wondering if we should wait with publishing this until shards is available as well?
@HertzDevil WDYT?

@HertzDevil
Copy link
Contributor

The Shards PR for MSYS2 is msys2/MINGW-packages#23361, in case you are wondering. It is a separate package (same as Arch Linux).

@straight-shoota
Copy link
Member Author

straight-shoota commented Feb 12, 2025

I have added shards to the instructions.
However with this I also felt it's a bit crowdy and hard to read. So I added labels in between the examples.
grafik

But this is still quite bulky.

So I've tried splitting into separate package entries:
grafik

I believe that makes more sense, even though they're all in MSYS2 and the first column should ideally be connected.
But that's not possible without changing the layout.

We could do is remove the labels in the other rows:
grafik

IMO that's not much improvement so I'm staying with number two.

_data/packages.yaml Outdated Show resolved Hide resolved
_data/packages.yaml Outdated Show resolved Hide resolved
@straight-shoota straight-shoota merged commit 4fc500d into crystal-lang:master Feb 13, 2025
5 checks passed
@straight-shoota straight-shoota deleted the feat/msys2-package branch February 13, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants