Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Union.from_json_object_key? #15411

Conversation

straight-shoota
Copy link
Member

Resolves part of #15403 (comment)

Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't hurt. One should prefer an explicit type rather than an union, but 🤷

@straight-shoota straight-shoota added this to the 1.16.0 milestone Feb 6, 2025
@straight-shoota straight-shoota merged commit a2573f9 into crystal-lang:master Feb 9, 2025
72 checks passed
@straight-shoota straight-shoota deleted the feat/union-from_json_object_key branch February 9, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants