Http Piece Retrival Test #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-pl
commented
Oct 23, 2023
integration/spadev0/util.go
Outdated
| @@ -164,7 +191,7 @@ func addErrorResults( | |||
| Task: task.Task{ | |||
| Requester: requester, | |||
| Module: "spadev0", | |||
| Metadata: spadev0Metadata, | |||
| Metadata: make(map[string]string), | |||
There was a problem hiding this comment.
Wasnt sure which metadata to use for the error unless we want to pass it around
There was a problem hiding this comment.
hmm, have a look at theaddErrorResults func in integration/filplus/util.go to see how it's done there. I originally copied from here but simplified as we only had one type - might be better to copy what they have.
stephen-pl
commented
Oct 23, 2023
| StatemarketdealsBatchSize Key = "STATEMARKETDEALS_BATCH_SIZE" | ||
| StatemarketdealsInterval Key = "STATEMARKETDEALS_INTERVAL" | ||
| PublicIP Key = "_PUBLIC_IP" | ||
| AcceptedContinents Key = "ACCEPTED_CONTINENTS" |
There was a problem hiding this comment.
Sorted this and got rid of the fil+ and statemarket deals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37 in RetrievalBot tasks