-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add tooltip, misc bug fixes, a11y fixes #59
base: develop
Are you sure you want to change the base?
Conversation
…panda into feat/tooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made that address this tickett all look great to me locally!
Thanks @joannaong & @timelytree !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These may be a bit nit picky @timelytree and @joannaong but here goes ->
- This is happen when I tab over the page that I'm on - looks like the focus ring is cut off. Not sure if this is too nit picky
- If I'm tabbing through through the site for the first time, I always have to hit the
enter
key twice on theFilters
button before the filter panel opens - If the Filters panel is open and I don't close it, once I tab off of the panel, the panel still stays open which obstructs the view of the datasets list. I know this is working as expected but I think, if we have time, we could add something where if the user tabs off of the panel, the panel closes.
Let me know what you all think! I can create tickets for any of these if we want to address then :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my end ! @joannaong @timelytree !
Description
Screenshots
Ticket link