Fix oliviertassinari#650: checkIndexBounds off by 1 validation

davidnx · Jun 27, 2021 · 19676b2 · 19676b2
1 parent a12dd90
commit 19676b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/react-swipeable-views-core/src/checkIndexBounds.js b/packages/react-swipeable-views-core/src/checkIndexBounds.js
@@ -7,8 +7,8 @@ const checkIndexBounds = props => {
   const childrenCount = React.Children.count(children);
 
   warning(
-    index >= 0 && index <= childrenCount,
-    `react-swipeable-view: the new index: ${index} is out of bounds: [0-${childrenCount}].`,
+    index >= 0 && index < childrenCount,
+    `react-swipeable-view: the new index: ${index} is out of bounds: [0-${childrenCount - 1}].`,
   );
 };
 

diff --git a/packages/react-swipeable-views-core/src/checkIndexBounds.test.js b/packages/react-swipeable-views-core/src/checkIndexBounds.test.js
@@ -28,13 +28,13 @@ describe('checkIndexBounds', () => {
 
   it('should warn when the index is out of bounds', () => {
     checkIndexBounds({
-      index: 3,
+      index: 2,
       children,
     });
     assert.strictEqual(consoleStub.callCount, 1);
     assert.strictEqual(
       consoleStub.args[0][0],
-      'Warning: react-swipeable-view: the new index: 3 is out of bounds: [0-2].',
+      'Warning: react-swipeable-view: the new index: 2 is out of bounds: [0-1].',
     );
   });
 });