Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyenv instead of system python to add macOS 12.3+ compatibility #92

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

willemml
Copy link

Exactly as the title says, as of macOS 12.3 Python 2.7 is no longer supported so this is a workaround until this is re-written for Python 3 or someone makes an alternative.

This is by no means an ideal fix, as it hugely complicates the installation process, but it is a fix. Another problem with this is that it unnecessarily inconveniences people who have not or cannot upgrade to macOS 12.3.

Temporary solution to #91.

@willemml
Copy link
Author

It was just pointed out to me that this depends on brew installing pyenv to /opt/homebrew/bin/pyenv. So if pyenv is installed somewhere else modifications need to be made.

@puttpotsawee
Copy link

@willemml I tried this and it works!
As an Alfred beginner, it took me a while to build and use the workflow.
before this gets merged, it would be great if you include the pre-build file in your git repo so other people won't waste their time trying it.

@willemml
Copy link
Author

@puttpotsawee glad to hear that it works! I did "build" this workflow and post it as a workflow file in a pre-release in my repo, but I only mentioned that in the issue (#91), not on this pull request. Here is a link to said release.

@puttpotsawee
Copy link

@willemml I didn't see the change in .alfredworkflow in the commit so I guess you didn't build it! Thank you so much for this. I hope @deanishe approve this merge request soon!

@willemml
Copy link
Author

Oh whoops, I didn't even realize there was one in the repository!

johanolde and others added 2 commits June 16, 2022 15:48
Changed the ghreleases URL to your fork, otherwise the fix doesn't work.
@kickthedragon
Copy link

Here's the exported workflow with @willemml changes. it works!
Convert.zip

@oldcai
Copy link

oldcai commented Dec 9, 2022

Here's the exported workflow with @willemml changes. it works! Convert.zip

It requires a pyenv-installed python version of pypy2.7-7.3.6.

If you have pyenv installed, run pyenv install pypy2.7-7.3.6, and it would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants