-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix too-long lines #260
Fix too-long lines #260
Conversation
Note: You should be getting a Strider preview on the PRs here in this repo. I have to fix the permissions; until I do that, I'm not sure changes here will publish to deconst.horse. It's a lower priority than a couple other things internally right now, but I'll get it done soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple notes on the README for consideration, but otherwise LGTM
|
||
## Building | ||
|
||
To build this documentation standalone, use the [Deconst client](https://github.com/deconst/client). Use the Sphinx preparer and a clone of `https://github.com/deconst/deconst-docs-control` as the control repository. | ||
To build this documentation standalone, use the [Deconst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should actually remove info around the Client since it's broken. Want to do that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preference is to leave this PR just about line length.
AFA the Client, do we ever plan to fix it? Here's an issue to track the discussion: #261
DNS entries for `deconst.horse`, `build.deconst.horse`, `staging.deconst.horse`, and `content.staging.deconst.horse` are managed by Cloud DNS entries in the "drgsites" account. They should be pointed to the appropriate load balancers. | ||
DNS entries for `deconst.horse`, `build.deconst.horse`, `staging.deconst.horse`, | ||
and `content.staging.deconst.horse` are managed by Cloud DNS entries in the | ||
"drgsites" account. They should be pointed to the appropriate load balancers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should take a look at pulling some of this out since it lives in the ops playbooks. Do you want me to do that, or would you prefer to look through on a first pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preference is to leave this PR just about line length.
Issue to track: #262
Approved. Issues opened for separate points. Merging. |
only includes reflow/whitespace changes