Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too-long lines #260

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Fix too-long lines #260

merged 1 commit into from
Mar 12, 2018

Conversation

robb-romans
Copy link
Contributor

only includes reflow/whitespace changes

@robb-romans robb-romans self-assigned this Mar 10, 2018
@robb-romans robb-romans changed the title Fix too-long lines [WIP] Fix too-long lines Mar 10, 2018
@robb-romans robb-romans changed the title [WIP] Fix too-long lines Fix too-long lines Mar 10, 2018
@nimbinatus
Copy link
Member

Note: You should be getting a Strider preview on the PRs here in this repo. I have to fix the permissions; until I do that, I'm not sure changes here will publish to deconst.horse. It's a lower priority than a couple other things internally right now, but I'll get it done soon.

Copy link
Member

@nimbinatus nimbinatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple notes on the README for consideration, but otherwise LGTM


## Building

To build this documentation standalone, use the [Deconst client](https://github.com/deconst/client). Use the Sphinx preparer and a clone of `https://github.com/deconst/deconst-docs-control` as the control repository.
To build this documentation standalone, use the [Deconst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually remove info around the Client since it's broken. Want to do that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference is to leave this PR just about line length.

AFA the Client, do we ever plan to fix it? Here's an issue to track the discussion: #261

DNS entries for `deconst.horse`, `build.deconst.horse`, `staging.deconst.horse`, and `content.staging.deconst.horse` are managed by Cloud DNS entries in the "drgsites" account. They should be pointed to the appropriate load balancers.
DNS entries for `deconst.horse`, `build.deconst.horse`, `staging.deconst.horse`,
and `content.staging.deconst.horse` are managed by Cloud DNS entries in the
"drgsites" account. They should be pointed to the appropriate load balancers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should take a look at pulling some of this out since it lives in the ops playbooks. Do you want me to do that, or would you prefer to look through on a first pass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference is to leave this PR just about line length.

Issue to track: #262

@robb-romans
Copy link
Contributor Author

Approved. Issues opened for separate points. Merging.

@robb-romans robb-romans merged commit f6be722 into deconst:master Mar 12, 2018
@robb-romans robb-romans deleted the rr-reformat-20180308 branch March 12, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants