fix hostname -I for macOS #6497 #6990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUGFIX for Apple Silicon hostname
loadams
reviewed
Feb 3, 2025
|
I'm having this same issue on arch linux. Thank you |
loadams
reviewed
Feb 4, 2025
| hostname_cmd = shlex.split("hostname -I") | ||
| result = subprocess.check_output(hostname_cmd) | ||
| master_addr = result.decode('utf-8').split()[0] | ||
| try: |
There was a problem hiding this comment.
@fitzjalen - could you also run the pre-commit formatter in order to meet the Formatting requirements?
There was a problem hiding this comment.
Thanks @fitzjalen - it looks like you'll need to use the new DCO to sign off on your commits. If you click the details button below it will give you information on how to rebase and fix this, thanks for your PR!
loadams
approved these changes
Feb 4, 2025
NVIDIA Blackwell GPU generation has number 10. The SM code and architecture should be `100`, but the current code generates `1.`, because it expects a 2 characters string. This change modifies the logic to consider it as a string that contains a `.`, hence splits the string and uses the array of strings. Signed-off-by: Fabien Dupont <[email protected]>
Signed-off-by: Olatunji Ruwase <[email protected]> Signed-off-by: Logan Adams <[email protected]> Signed-off-by: Fabien Dupont <[email protected]> Co-authored-by: Fabien Dupont <[email protected]>
Same as [this PR](deepspeedai#6922). [affeb88](deepspeedai@affeb88) I noticed the CI updated the DCO check recently. Using the suggested rebase method for sign-off would reintroduce many conflicts, so I opted for a squash merge with sign-off instead. thanks: ) Signed-off-by: inkcherry <[email protected]>
Signed-off-by: Roman Fitzjalen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGFIX for Apple Silicon hostname #6497