Adopt types for table features, fixed a few clippy warnings #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR just moves the string typed table features to adopt the numbers we already have specified for this. This should do the string conversion parsing only once instead of every time we check if table features are supported.
I also fixed 2 bug clippy made me aware of. One was using
.next_back()
vs..last()
since it was a double ended iterator. And the other was an error message on a deletion vector's length not being long enough where it would emit an error message that has an unformatted capture variable in it.This PR affects the following public APIs
This changes the underlying type signature Protocol exposes from
Option<Vec<String>>
to it's associated table feature enum.ReaderFeatures
andWriterFeatures
respectively.How was this change tested?
Test cases were altered to suit the new usage, but for the most part a lot of general parsing was remove albeit the cost is some code duplication.