generate dkim_selector with cmdeploy init #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happens though if you and me deploy to nine.testrun.org from time to time? We will have different selectors and keep switching between them, should be fine? |
should be fine as long as we take care to publish the corresponding DNS records. (If CI would take care of deploying to nine the publishing of DNS records to ns.testrun.org could even be automated.) |
missytake
force-pushed
the
staging-ci
branch
3 times, most recently
from
c2145ba to
181b04b
Compare
missytake
changed the title
|
Let's only do it on staging.testrun.org for now. |
2 tasks
missytake
force-pushed
the
staging-ci
branch
4 times, most recently
from
8e707ea to
9523632
Compare
missytake
force-pushed
the
generate-dkim-selector
branch
from
42f9e03 to
03a367a
Compare
|
This is not necessary anymore, as staging.testrun.org isn't reset on every run. |
|
Generating selectors may be interesting for #195, but for now it is ok that we have a static key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably we should not generate it in
cmdeploy init, but instead check if there is already a DKIM key.