fix(compile): never include the specified output executable in itself #27877
+60
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
requested changes
Jan 30, 2025
cli/tools/compile.rs
Outdated
| let file_index = include_files.iter().position(|file_included| { | ||
| file_included | ||
| .path() | ||
| .ends_with(output_path.to_str().unwrap().replace(" ", "%20").as_str()) |
There was a problem hiding this comment.
I don't think this will work on windows. It should probably be converted to a url first. Can you add a test for this change?
There was a problem hiding this comment.
I investigated this and found out the reason it was working is because output_path happened to be the filename in the tests. I updated it to use the full path instead.
There was a problem hiding this comment.
(this won't work on Windows because urls use forward slashes, but windows uses backslashes)
dsherret
reviewed
Feb 5, 2025
Signed-off-by: David Sherret <[email protected]>
Co-authored-by: David Sherret <[email protected]> Signed-off-by: HasanAlrimawi <[email protected]>
…Alrimawi/deno into compile-exclude-executable
…Alrimawi/deno into compile-exclude-executable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27796
Change
Check if the output executable file is within the included files to be compiled, and remove it if so.