101987 Removed champva_multiple_stamp_retry feature toggle and improved handle_upload - IVC CHAMPVA forms

[michaelclement]

Summary

• Delete the champva_multiple_stamp_retry flipper
• Delete all references to the flipper
• Delete all code that would have been used when the flipper was disabled
• Delete the rubocop:disable Metrics/MethodLength and rubocop:enable Metrics/MethodLength statements around handle_file_uploads
• Adjusted the return value of handle_uploads when champva_require_all_s3_success is disabled so that subarrays are padded with nils (NOTE: this flipper is enabled, so this change shouldn't impact production, but it was necessary to update this for consistency's sake)

Related issue(s)

• Remove champva_multiple_stamp_retry flipper va.gov-team#101987

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

IVC CHAMVPA forms

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

NA

[michaelclement]

Updated handle_file_uploads method to remove the champva_multiple_stamp_retry toggle check and the associated extra branch of functionality.

[michaelclement]

Adjusted tests so there are no longer references to the feature toggle that was removed.

[cloudmagic80]

LGTM

[rmtolmach]

👍
Once this is deployed, you'll need to follow step 3 of this section of this guide to completely remove this toggle. You'll need to do it in the terminal of each ArgoCD environment. If you or no one on your team has access to those terminals, let me know and I can do it for you. Remember, don't delete them in Argo until the code has been deployed.