Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 44800 itf web service spec file #20677

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rockwellwindsor-va
Copy link
Contributor

Summary

  • Updates test params format
  • Records over the old cassettes

Related issue(s)

API-44800

Testing done

  • New code is covered by unit tests

Screenshots

Note: Optional

What areas of the site does it impact?

modified:   modules/claims_api/spec/lib/claims_api/bgs/itf_web_service_spec.rb
modified:   spec/support/vcr_cassettes/claims_api/bgs/intent_to_file_web_service/insert_intent_to_file.yml
modified:   spec/support/vcr_cassettes/claims_api/bgs/intent_to_file_web_service/insert_intent_to_file_500.yml

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

* Updates test params format
* Records over the old cassettes
	modified:   modules/claims_api/spec/lib/claims_api/bgs/itf_web_service_spec.rb
	modified:   spec/support/vcr_cassettes/bgs/intent_to_file_web_service/insert_intent_to_file_500.yml
	modified:   spec/support/vcr_cassettes/claims_api/bgs/intent_to_file_web_service/insert_intent_to_file.yml
	modified:   spec/support/vcr_cassettes/claims_api/bgs/intent_to_file_web_service/insert_intent_to_file_500.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants