Feature: Add CLI params for authentication #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2017
Open
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "deployd-cli", | |||
| "version": "2.0.0", | |||
| "version": "0.0.2", | |||
There was a problem hiding this comment.
Please, keep version 2.0.0
lib/cli/start.js
Outdated
| password = auth[1]; | ||
| setCredentials(username, password); | ||
| } else if (program.username || program.password) { | ||
| console.log(' program.password', program.password) |
There was a problem hiding this comment.
do not output the password in the logs
There was a problem hiding this comment.
great catch. I'll remove this line, was for test
lib/cli/start.js
Outdated
| ); | ||
|
|
||
|
|
||
| // Added by PV |
There was a problem hiding this comment.
just note that where I made the change
added dpd.config to set dpd configurations to comply naming convention , that will replace app.dpd
.travis.yml
Outdated
| @@ -0,0 +1,3 @@ | |||
| language: node_js | |||
There was a problem hiding this comment.
can you use the same as deployd?
https://github.com/deployd/deployd/blob/master/.travis.yml
.travis.yml
Outdated
| - "6" | ||
| - "5" | ||
| - "4" | ||
| - "0.12" |
There was a problem hiding this comment.
it needs a tab (you can validate your travis.yml here: http://lint.travis-ci.org/)
NicolasRitouet
changed the title
NicolasRitouet
approved these changes
Jul 19, 2017
NicolasRitouet
changed the title
|
@moorthi07 Thanks a lot for your contribution 🎉 |
|
Right back at you! thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7 dpd start with mongodb authentication fixed
Issue #8 version no. in package.json fixed.
Issue #4 Keygen works as expected.