Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[universal] - check toolings - monthly task #1273

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+9 −9
Open

[universal] - check toolings - monthly task #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9fa4150
Updating node and ruby pinned versions for universal image
Kaniska244 Dec 30, 2024
26433d1
Updating node and ruby pinned versions for universal image
Kaniska244 Dec 30, 2024
fde3f96
Updating node and ruby pinned versions for universal image
Kaniska244 Dec 30, 2024
f40b3e1
Merge branch 'main' into universal_monthly_task_update_pinned_version
Kaniska244 Jan 10, 2025
897aba2
Update test.sh to test universal smoke test
Kaniska244 Jan 16, 2025
e10f06b
To check the GitHub runner credential
Kaniska244 Jan 21, 2025
02d71f8
Reverting the debug statements
Kaniska244 Jan 21, 2025
9b6e35a
Merge branch 'main' into universal_monthly_task_update_pinned_version
Kaniska244 Feb 10, 2025
eaa89f3
Testing the disable Apparmor
Kaniska244 Feb 10, 2025
b2cf99c
Reverting the fixes
Kaniska244 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/smoke-base-alpine.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- name: Checkout
id: checkout
uses: actions/checkout@v3
uses: actions/checkout@v3

- name: Smoke test
id: smoke_test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke-universal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: actions/checkout@v3
- name: Smoke test
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
id: smoke_test
uses: ./.github/actions/smoke-test
with:
Expand Down
8 changes: 4 additions & 4 deletions src/universal/.devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"version": "latest"
},
"ghcr.io/devcontainers/features/node:1": {
"version": "20",
"additionalVersions": "18"
"version": "22",
"additionalVersions": "20"
},
"./local-features/nvs": "latest",
"ghcr.io/devcontainers/features/python:1": {
Expand All @@ -39,8 +39,8 @@
"version": "latest"
},
"ghcr.io/devcontainers/features/ruby:1": {
"version": "3.3.4",
"additionalVersions": "3.3.2"
"version": "3.4.1",
"additionalVersions": "3.3.6"
},
"ghcr.io/devcontainers/features/java:1": {
"version": "21",
Expand Down
2 changes: 1 addition & 1 deletion src/universal/.devcontainer/local-features/setup-user/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ find "${OPT_DIR}" -type d | xargs -n 1 chmod g+s
echo "Defaults secure_path=\"${DOTNET_PATH}:${NODE_PATH}/bin:${PHP_PATH}/bin:${PYTHON_PATH}/bin:${JAVA_PATH}/bin:${RUBY_PATH}/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/bin:/usr/local/share:/home/${USERNAME}/.local/bin:${PATH}\"" >> /etc/sudoers.d/$USERNAME

# Temporary: Due to GHSA-c2qf-rxjj-qqgw
bash -c ". /usr/local/share/nvm/nvm.sh && nvm use 18"
bash -c ". /usr/local/share/nvm/nvm.sh && nvm use 22"
bash -c "npm -g install -g [email protected]"
bash -c ". /usr/local/share/nvm/nvm.sh && nvm use stable"

Expand Down
4 changes: 2 additions & 2 deletions src/universal/test-project/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ expectedCount=2
checkVersionCount "two versions of node are present" $count $expectedCount
echo $(echo "node versions" && ls -a /usr/local/share/nvm/versions/node)
checkBundledNpmVersion "default" "9.8.0"
checkBundledNpmVersion "18" "9.8.1"
checkBundledNpmVersion "22" "9.8.1"

# PHP
check "php" php --version
Expand Down Expand Up @@ -140,7 +140,7 @@ check "run-puppeteer" node puppeteer.js
check "oryx" oryx --version

# Ensures nvm works in a Node Project
check "default-node-version" bash -c "node --version | grep 20."
check "default-node-version" bash -c "node --version | grep 22."
check "default-node-location" bash -c "which node | grep /home/codespace/nvm/current/bin"
check "oryx-build-node-projectr" bash -c "oryx build ./sample/node"
check "oryx-configured-current-node-version" bash -c "ls -la /home/codespace/nvm/current | grep /opt/nodejs"
Expand Down
Loading