add toDictionary, toJSONString #2

iamchiwon · 2018-01-02T06:42:42Z

My project using Firebase, needs convertings between Model and Dictionary, [String:Any].
So I added "toDictionary()"
and "toJSONString()" for POST request

when error occured, toDictionay() and toJSONString() returns empty not nil , followed your map() that returns empty Data when error
respected your coding convention, 2 space indent, and space after colon

codecov-io · 2018-01-02T06:57:35Z

Codecov Report

Merging #2 into master will decrease coverage by 4.87%.
The diff coverage is 83.56%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage    92.5%   87.62%   -4.88%     
==========================================
  Files           4        3       -1     
  Lines          40       97      +57     
  Branches        3        0       -3     
==========================================
+ Hits           37       85      +48     
- Misses          0       12      +12     
+ Partials        3        0       -3

Impacted Files	Coverage Δ
Sources/RxCodable/ObservableType+RxCodable.swift	`87.09% <82.6%> (-3.82%)`	⬇️
Sources/RxCodable/Single+RxCodable.swift	`87.87% <84%> (-3.04%)`	⬇️
Sources/RxCodable/Maybe+RxCodable.swift	`87.87% <84%> (-3.04%)`	⬇️
Sources/TestUtil/Fixture.swift

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4c053...ef78616. Read the comment docs.

devxoul · 2018-01-02T14:48:38Z

Sources/RxCodable/ObservableType+RxCodable.swift

+}
+
+public extension ObservableType where E: Encodable {
+  public func toDictionary() -> Observable<[String:Any]> {


How about renaming it to mapDictionary()?

I think we need a parameter of JSONEncoder. map() takes an instance of JSONDecoder as a parameter.

Could you please append a whitespace after a colon?
- [String:Any] + [String: Any]

How do you think of supporting mapping json array?

like toBlocking(), toArray(). toXXX() feels extract some data. toDictionary() is more clear for me, aren't you? ( I understand your side, changing data should start with map... )

Yes. It seems necessary

my mistake.

why not

It's not about extracting data. It's obviously mapping data. I think it would be better to rename it to mapDictionary().

✅

✅

Could you write that one?

then toJSONString() needs rename to mapJSONString(), too?

devxoul · 2018-01-02T14:49:25Z

Sources/RxCodable/ObservableType+RxCodable.swift

+    return self.map { encodable -> [String: Any] in
+      let data = try JSONEncoder().encode(encodable)
+      let dictionary = try JSONSerialization.jsonObject(with: data) as? [String: Any]
+      return dictionary ?? [:]


This default value can cause an unexpected result. I think we should treat a casting failure as an error.

good point!
access empty dictionary makes crash.. it would be better throw error

unit test testMapCodableArrayToJSONString() added : [Encodable] -> toJSONString()

…Encoding

iamchiwon · 2018-01-03T04:17:25Z

toDictionary(), toJSONString() got parameter JSONEncoder as first with no name.
toDoctionary() throws RxError.noElements.
RxError.noElements seems not exactly matched, but I don't want to create new ErrorType
UnitTest added, that shows [Encodable] ==> JSON string.

devxoul · 2018-01-03T05:34:16Z

Sources/RxCodable/Maybe+RxCodable.swift

+    return self.map { encodable -> [String: Any] in
+      let data = try (encoder ?? JSONEncoder()).encode(encodable)
+      let dict = try JSONSerialization.jsonObject(with: data) as? [String: Any]
+      guard let dictionary = dict else { throw RxError.noElements }


RxError.noElements should not be used here. It would be better to create a new error type for RxCodable.

hmm.. It should be

how about this?

enum RxCodableError : Error, CustomDebugStringConvertible { case decodeFail case encodeFail var debugDescription: String { switch self { case .decodeFail: return "Encoding failure" case .encodeFail: return "Decoding failure" } } }

We should give more detailed information. And CustomDebugStringConvertible is not necessary.

enum RxCodableError: Error { case castingFailure(Any, Any.Type) }

You can refer to RxJSONError.

devxoul · 2018-01-03T05:34:29Z

Sources/RxCodable/Maybe+RxCodable.swift

+    return self.map { encodable -> String in
+      let data = try (encoder ?? JSONEncoder()).encode(encodable)
+      let json = String(data: data, encoding: encoding)
+      return json ?? "{}"


Please don't use default value here.

RxCodableError added. thows mapDictionary, mapJSONString feature added that mapping [Dictionary] ==> [Encodable]

devxoul · 2018-01-05T11:28:26Z

Sources/RxCodable/ObservableType+RxCodable.swift

+}
+
+public extension ObservableType where E == [[String: Any]] {
+  public func map<T>(_ type: Array<T>.Type, using decoder: JSONDecoder? = nil) -> Observable<[T]> where T: Decodable {


What is this? The 'array mapping' I meant was about func mapArray() which maps Observable<[T]> to Observable<[[String: Any]]>.

Oh.. my misunderstood. now I see.

Hmm.. It's not as easy as I thought.

iamchiwon-ncode added 2 commits January 2, 2018 12:27

adding [String:Any] type

a044722

add toDictionay, toJSONString

7df8bfe

devxoul requested changes Jan 2, 2018

View reviewed changes

iamchiwon-ncode added 2 commits January 3, 2018 12:02

toDictionay, toJSONString got JSONEncoder parameter

770349a

unit test testMapCodableArrayToJSONString() added : [Encodable] -> toJSONString()

toJSONString parameter order changed: first JSONEncoder, last String.…

c07dd44

…Encoding

devxoul requested changes Jan 3, 2018

View reviewed changes

rename toDictionary -> mapDictionary, toJSONString -> mapJSONString

ef78616

RxCodableError added. thows mapDictionary, mapJSONString feature added that mapping [Dictionary] ==> [Encodable]

devxoul requested changes Jan 5, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add toDictionary, toJSONString #2

add toDictionary, toJSONString #2

iamchiwon commented Jan 2, 2018

codecov-io commented Jan 2, 2018 •

edited

Loading

devxoul Jan 2, 2018

iamchiwon Jan 3, 2018

devxoul Jan 3, 2018 •

edited

Loading

iamchiwon Jan 3, 2018

devxoul Jan 2, 2018

iamchiwon Jan 2, 2018

iamchiwon commented Jan 3, 2018

devxoul Jan 3, 2018

iamchiwon Jan 3, 2018

iamchiwon Jan 3, 2018 •

edited

Loading

devxoul Jan 3, 2018 •

edited

Loading

devxoul Jan 3, 2018

iamchiwon Jan 3, 2018

devxoul Jan 5, 2018

iamchiwon Jan 8, 2018

iamchiwon Jan 17, 2018

add toDictionary, toJSONString #2

Are you sure you want to change the base?

add toDictionary, toJSONString #2

Conversation

iamchiwon commented Jan 2, 2018

codecov-io commented Jan 2, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devxoul Jan 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamchiwon commented Jan 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamchiwon Jan 3, 2018 • edited Loading

Choose a reason for hiding this comment

devxoul Jan 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Jan 2, 2018 •

edited

Loading

devxoul Jan 3, 2018 •

edited

Loading

iamchiwon Jan 3, 2018 •

edited

Loading

devxoul Jan 3, 2018 •

edited

Loading