Draft: Don't display confirm following for not votable neurons

[mstrasinskis]

Motivation

In today's implementation, you can have neurons that are unlocked but have been inactive for so long that the "confirm following" warning appears. This is undesired, so the followee confirmation warning shouldn't be shown if the neuron cannot vote.

This applies to banners, tags, and the neuron activity action field.

Changes

• Rename shouldDisplayMissingRewardNotification to isNeuronMissingRewardSoon because, with the new rule, it no longer reflects what it does.
• Add the utility function hasEnoughDissolveDelayToVote.
• Apply the new utility to soonLosingRewardNeuronsStore to filter out neurons that don't have enough dissolve delay to vote.
• Use the new utility for missing rewards tag visibility.
• Use the new utility for NeuronRewardStatusAction field visibility.
• Use the new utility for ConfirmFollowingBanner visibility.

Tests

• Add dissolveDelaySeconds to addNeuronWith.
• Add related to new logic tests.
• Ensure that other missing rewards related tests have a valid dissolve delay.
• Tested manually.

Todos

• Add entry to changelog (if necessary).
  Not necessary.

[dskloetd]

There's a lot going on here. Do you think you can split it?

[mstrasinskis]

There's a lot going on here. Do you think you can split it?

Sure, some changes can be split into separate PRs 👍