feat: skip transition in test for transition.utils #6395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
dskloetd
reviewed
Feb 11, 2025
| @@ -8,6 +8,11 @@ export const heightTransition = ( | |||
| duration?: number; | |||
| } | |||
| ) => { | |||
| // Prevent "TypeError: Cannot set properties of undefined (setting 'onfinish')" in vitest mode | |||
| if (process.env.NODE_ENV === "test") { | |||
There was a problem hiding this comment.
Please do this in a way that doesn't disable it in the test for the transition itself so it doesn't break the test.
There was a problem hiding this comment.
Yeah I don't know how. Created the draft to start the discussion. If you guys can take care of this, happy to close this PR afterwards.
There was a problem hiding this comment.
Yeah I don't know how.
Does this help?
nns-dapp/frontend/src/lib/constants/mockable.constants.ts
Lines 2 to 3 in 6d5fbff
There was a problem hiding this comment.
Thanks. I can have a look next week or so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Svelte v5 requires the web animation API which is not supported in emulated testing environment. That's why this PR makes
transition.utilsskip animating in test mode.Notes
Changes
process.env.NODE_ENV === "test"then no animation