Clarify ingress expiry semantics #5080
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
interface-spec
|
🤖 Here's your preview: https://hhcgk-raaaa-aaaam-abahq-cai.icp0.io |
yvonneanne
commented
Feb 12, 2025
THLO
reviewed
Feb 12, 2025
|
|
||
| The synchronous call endpoint is useful for users as it removes the networking overhead of polling the IC to determine the status of their call. | ||
| The synchronous call endpoint is useful for users as it removes the networking overhead of polling the IC to determine the status of their call if a terminal state is reached quickly. |
There was a problem hiding this comment.
I'm not sure how to best improve it but "reached quickly" is vague, right?
There was a problem hiding this comment.
I agree, but imo it is simply incorrect without it...
An alternative could be the following, wdyt?
Suggested change
| The synchronous call endpoint is useful for users as it removes the networking overhead of polling the IC to determine the status of their call if a terminal state is reached quickly. | |
| The synchronous call endpoint is useful for users as it reduces the networking overhead of polling the IC to determine the status of their call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request's
ingress_expirykeeps raising questions.This PR adds clarifications to the different semantics for
callandread_state.