Preserve the pipeline order when async receiving packets #3351
+5
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the oldest open issues in Floodgate GeyserMC/Floodgate#143.
ProtocolLib their async packet handlers currently don't respect the pipeline order and instead always let the Minecraft Connection class handle everything.
The Floodgate issue describes the following scenario:
A packet handler is created for
PacketType.Login.Client.START
, and when it comes time to handle that packet the async handler cancels the packet and keeps a copy for later use. If the packet is not async thenctx#fireChannelRead
is executed. When the plugin is done handling that packetreadServerboundPacket
sends it to the Connection class without considering that there might be other channel handlers between ProtocolLib and Minecraft'spacket_handler
.This PR calls
ctx#fireChannelRead
, fixing the order that was broken.