Trying out gha to run tests #7073
Conversation
| @@ -304,6 +306,17 @@ public static IResourceBuilder<PostgresServerResource> WithPgWeb(this IResourceB | |||
| Directory.CreateDirectory(serverFileMount.Source!); | |||
| } | |||
|
|
|||
| // Need to grant read access to the config file on unix like systems. | |||
There was a problem hiding this comment.
Why wasn't this needed before?
There was a problem hiding this comment.
Not sure how our machines or docker is setup.
@danegsta ideas?
There was a problem hiding this comment.
The need for custom file permissions on Mac/Linux really depends on the specific container. If the container is running as root, it’s not really necessary, but if a container is running as a custom user, then we have to jump through hoops to make sure that user will be able to read the mounted file. So if the pgweb image started using a specific user instead of root, that’d necessitate the change.
There was a problem hiding this comment.
Its strange we dont need this on our other machine though right? I had to add it here because I saw permission errors
There was a problem hiding this comment.
I know this is per container, but I wonder if we can as part of creating a BindMount if we should allow setting these flags..
There was a problem hiding this comment.
Take a look at the new changes I made WRT bind mounts in the latest commits. I made it first class on bind mount and calls to WithBindMount can opt into what per resource.
I think we solve this on an integration by integration basis depending on what minimum permissions that bind mount needs based on the interaction with the container. I still don't know why I had to make these changes in this pr to make it work though.
tests/Aspire.Hosting.Tests/Utils/TestDistributedApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
danmoseley
added
the
area-engineering-systems
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Build projects | ||
| run: | | ||
| dotnet build ${{ matrix.project }} -c Release /p:CI=false --no-restore |
There was a problem hiding this comment.
What is /p:CI=false for? Also, as a NIT, I'm assuming we could theoretically collapse restore, build and test phase into a single command as I believe dotnet test should do all of that.
There was a problem hiding this comment.
Might also be good to remove the -c Release as Debug will help having more actionable info in callstack in case test fails.
There was a problem hiding this comment.
What is /p:CI=false for? Also, as a NIT, I'm assuming we could theoretically collapse restore, build and test phase into a single command as I believe dotnet test should do all of that.
I get this #5956
tests/Aspire.Hosting.Elasticsearch.Tests/ElasticsearchFunctionalTests.cs
Outdated
Show resolved
Hide resolved
davidfowl
force-pushed
the
davidfowl/gha-experiment
branch
from
8cd4272 to
8bae5d6
Compare
| if (mount.Type == ContainerMountType.BindMount && | ||
| mount.UnixFileMode is not null && |
There was a problem hiding this comment.
Evaluate the mount with pattern matching.
| if (mount.Type == ContainerMountType.BindMount && | |
| mount.UnixFileMode is not null && | |
| if (mount is { Type: ContainerMountType.BindMount, UnixFileMode: not null } && |
Co-authored-by: David Pine <[email protected]>
Run integration tests on github actions as individual jobs for maximum concurrency.
This pull request introduces a variety of changes aimed at enhancing the functionality and robustness of the Aspire Hosting project. The most significant updates include the addition of integration tests, the introduction of Unix file mode settings for bind mounts, and various improvements to the PostgreSQL and Redis components.
Fixes #4599