-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed tracing in networking #44063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great content. Lets make the changes to the core telemetry example so you don't need to document how to modify it.
Co-authored-by: Sam Spencer <[email protected]>
Co-authored-by: Sam Spencer <[email protected]>
…/docs into af/network-tracing-2
@gewarren would you mind doing a language review on this? (Though I think it's mostly ok, so it's optional.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait to review the rest until you've run Acrolinx (see one of the comments I left).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't finish reviewing tracing.md, as it seems to duplicate a lot of the content in metrics.md. I'm guessing that's not intentional, so will hold off on reviewing the rest.
Co-authored-by: Genevieve Warren <[email protected]>
@gewarren thanks a lot for chiming in, the content looks much better now! |
This is a major rework of #42830, extending the content, making the information more specific and IMO easier to follow. The biggest change is the in the collection paragraphs:
Metrics.md
: Added back thedotnet-monitor
example. Reintroduced a short paragraph on prometheus/grafana, since the referenced docs need some augmentation.Internal previews