-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ILC after ComputeResolvedFilesToPublishList #111514
base: main
Are you sure you want to change the base?
Conversation
Did you consider using the scheme that ILLink/R2R/SingleFile use right now? It feels like it would make the sequencing most "standard". We'd probably need to wait for the new SDK to flow to this repo but we just did an upgrade and we could do another one. |
This moves us in that direction - now this target will be sequenced appropriately - and we can change from AfterTargets to DependsOnTargets in a later change. I'm looking at the native aot targets all-up to see if there's other logic that needs cleanup, but wanted to start with this piece. |
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Show resolved
Hide resolved
(The CI failures look related) |
/azp run runtime-ioslike |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
@ivanpovazan is there going to be any work required in the iOS SDK as a result of this change? |
No, because we opt-out from NativeAOT Publish targets and handle them differently: |
@sbomer ios/tvos test failures seem related, let me know if I can help with those. |
Fixes #108909
Needs more testing, but seems to work with a small repro so far.