Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn-analyzers #111518

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[main] Update dependencies from dotnet/roslyn-analyzers #111518

wants to merge 5 commits into from
+6 −6

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 17, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
  • Build: 20250126.4
  • Date Produced: January 26, 2025 9:03:11 AM UTC
  • Commit: 3746107f6c9e0a2f1cae7e37a78a9d9de249857a
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
88b11c5 
…uild 20250116.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.12.0-beta1.24629.1 -> To Version 3.12.0-beta1.25066.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jan 17, 2025
This was referenced Jan 17, 2025
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
86ec80a 
…uild 20250122.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.12.0-beta1.24629.1 -> To Version 3.12.0-beta1.25072.1
@build-analysis build-analysis bot mentioned this pull request Jan 23, 2025
Open
3 tasks
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
4491a0e 
…uild 20250123.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.12.0-beta1.24629.1 -> To Version 3.12.0-beta1.25073.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
3e21c6d 
…uild 20250124.5

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.12.0-beta1.24629.1 -> To Version 3.12.0-beta1.25074.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
0a321b2 
…uild 20250126.4

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.12.0-beta1.24629.1 -> To Version 3.12.0-beta1.25076.4
@build-analysis build-analysis bot mentioned this pull request Jan 27, 2025
Open
3 tasks
@ViktorHofer
Copy link
Member

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RuntimeMetrics.cs(179,59): error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'Environment.CpuUsage' is unsupported on: 'maccatalyst'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)

cc @tarekgh

@tarekgh
Copy link
Member

tarekgh commented Jan 30, 2025

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RuntimeMetrics.cs(179,59): error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'Environment.CpuUsage' is unsupported on: 'maccatalyst'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)

I am not sure if this is a valid violation. @akoeplinger has fixed that before in the PR #105409.

The code is clearly marking the method with [UnsupportedOSPlatform("ios")] and [SupportedOSPlatform("maccatalyst")]. The method is calling Environment.CpuUsage which is also marked with [UnsupportedOSPlatform("ios")] and [SupportedOSPlatform("maccatalyst")]. I am not seeing anything wrong here.

@akoeplinger may confirm that and maybe someone help with that analyzer or at least explain if we are missing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @tarekgh