Improve char.IsWhiteSpace for non-ASCII #111569
Open
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
char.IsWhiteSpace
looks something likeIf you just run a microbenchmark over this with non-ASCII input, things will be fine as PGO will inline the whole thing together.
But if
IsWhiteSpace
ends up tiering up without seeing data super skewed for non-ASCII, theGetCategoryCasingTableOffsetNoBoundsChecks
call in the fallback case won't be inlined, slowing down any future queries for non-ASCII chars.