fix(osp): applied regex validation on uniqueIds param #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfjanjua
requested review from
Phil91,
dhiren-singh-007 and
ntruchsess
and removed request for
dhiren-singh-007
ntruchsess
requested changes
Nov 19, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
please take care of codeql finding |
|
changes looks fine, after the fix of the codeQl finding we can merge the pr imo |
|
|
@evegufy | @Phil91 | @ntruchsess |
Phil91
previously approved these changes
Jan 14, 2025
|
Hi @Phil91 | @ntruchsess |
tfjanjua
force-pushed
the
fix/1157-regex-validation-uniqueIds
branch
from
90057fc to
3a07d78
Compare
tfjanjua
force-pushed
the
fix/1157-regex-validation-uniqueIds
branch
2 times, most recently
from
fc0d0fa to
460d738
Compare
ntruchsess
force-pushed
the
fix/1157-regex-validation-uniqueIds
branch
from
db796b7 to
e1fa162
Compare
ntruchsess
approved these changes
Feb 6, 2025
|
ntruchsess
dismissed
evegufy’s stale review
conflicts have been resolved by rebase on main and subsequent update of framework-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied one more validation on
uniqueIdsparam through regex.Why
Currently, request is being validated with invalid data e.g: "VAT ID" --> “value“ : “XYZ“
Issue
Ref: #1157
Checklist