Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ftdetect files #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Delete ftdetect files #244

wants to merge 1 commit into from

Conversation

xuhdev
Copy link
Member

@xuhdev xuhdev commented Jan 10, 2025

As discussed in
#243 (comment), Vim and Neovim already support detecting editorconfig files. Our ftdetect still leads Vim to use dosini file type, which is not fully optimized for .editorconfig.

As discussed in
#243 (comment),
Vim and Neovim already support detecting editorconfig files. Our ftdetect still
leads Vim to use dosini file type, which is not fully optimized for .editorconfig.
@xuhdev xuhdev requested a review from cxw42 January 10, 2025 22:15
Copy link
Member

@cxw42 cxw42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but I haven't had a chance to test it.

Would it be worth updating the README or changelog to let people know they need to check out the commit before this one on Vim 7 or other *Vim not having the editorconfig file type built in?

@xuhdev
Copy link
Member Author

xuhdev commented Jan 14, 2025

Sure. How about we make a tagged release before merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants