Fix unknown compiler crash printing 'null' #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiribenes
commented
Jan 15, 2025
Comment on lines
+118
to
+121
| def getStackTrace(e: Throwable): String = | ||
| val stringWriter = new java.io.StringWriter() | ||
| e.printStackTrace(new java.io.PrintWriter(stringWriter)) | ||
| stringWriter.toString |
There was a problem hiding this comment.
This part is essentially cherry-picked from the discussion in @JakubSchwenkbeck's #731. Thanks!
dvdvgt
approved these changes
Jan 15, 2025
dvdvgt
pushed a commit
that referenced
this pull request
Jan 17, 2025
Resolves the `Effect Compiler Crash: null` part of #760. The actual problem there was that `e.getMessage` can return `null` and it does for... _StackOverflowException_ 🥳. Looking at the docs, it's recommended to use `e.toString`. While I was at it, I modified stack trace printing, now we do it properly by using `.printStackTrace`. This is very related to #731, I just want to get this out quickly to unblock other problems.
EveEme
pushed a commit
to EveEme/effekt
that referenced
this pull request
Jan 20, 2025
Resolves the `Effect Compiler Crash: null` part of effekt-lang#760. The actual problem there was that `e.getMessage` can return `null` and it does for... _StackOverflowException_ 🥳. Looking at the docs, it's recommended to use `e.toString`. While I was at it, I modified stack trace printing, now we do it properly by using `.printStackTrace`. This is very related to effekt-lang#731, I just want to get this out quickly to unblock other problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the
Effect Compiler Crash: nullpart of #760.The actual problem there was that
e.getMessagecan returnnulland it does for... StackOverflowException 🥳.Looking at the docs, it's recommended to use
e.toString.While I was at it, I modified stack trace printing, now we do it properly by using
.printStackTrace.This is very related to #731, I just want to get this out quickly to unblock other problems.