Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add more docs and comments #19

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Conversation

oblique
Copy link
Member

@oblique oblique commented Jan 26, 2024

No description provided.

@oblique oblique requested review from fl0rek and zvolin January 26, 2024 17:33
@oblique oblique marked this pull request as ready for review January 29, 2024 10:31
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left few nits

oblique and others added 2 commits January 29, 2024 12:46
@oblique oblique requested a review from zvolin January 29, 2024 10:50
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits, otherwise LGTM!

src/builder.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/wantlist.rs Outdated Show resolved Hide resolved
src/wantlist.rs Outdated Show resolved Hide resolved
oblique and others added 5 commits January 30, 2024 14:28
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
@fl0rek fl0rek merged commit 914452f into eigerco:main Jan 30, 2024
5 checks passed
This was referenced Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants