fix logstash-keystore to accept spaces in values when added via stdin (…

…#17039) (#17041)

This commit preserves spaces in values, ensuring that multi-word strings are stored as intended.
Prior to this change, `logstash-keystore` incorrectly handled values containing spaces,
causing only the first word to be stored.

(cherry picked from commit 5573b5a)

Co-authored-by: kaisecheng <[email protected]>

logstash-core/src/main/java/org/logstash/secret/cli/Terminal.java

@@ -81,7 +81,7 @@ public char[] readSecret() {
         if (useConsole) {
             return System.console().readPassword();
         } else {
-            return scanner.next().toCharArray();
+            return scanner.nextLine().toCharArray();
         }
     }
 

qa/integration/specs/secret_store_spec.rb

@@ -87,6 +87,20 @@
     expect(logstash.stderr_and_stdout).to match(/\\"\$\{tag1\}\\"/)
   end
 
+  it "add value that contains a space" do
+    # add two key value pairs to keystore
+    # hello => hello world
+    # bye => bye
+    key = "hello"
+    value = "hello world"
+    @logstash.run_cmd(["bash", "-c", "echo -e '#{value}\\nbye' | LOGSTASH_KEYSTORE_PASS=#{logstash_keystore_passowrd} #{@logstash.logstash_home}/bin/logstash-keystore --path.settings #{settings_dir} add #{key} bye"])
+
+    test_env["LOGSTASH_KEYSTORE_PASS"] = logstash_keystore_passowrd
+    logstash = @logstash.run_cmd(["bin/logstash", "-e", "input{ generator{ count => 1 tags => ['${#{key}}', '${bye}'] }}", "--path.settings", settings_dir], true, test_env)
+    expect(logstash.stderr_and_stdout).to match(/#{value}/)
+    expect(logstash.stderr_and_stdout).to match(/bye/)
+  end
+
   context "won't start" do
     it "with the wrong password when variables are in settings" do
       test_env["LOGSTASH_KEYSTORE_PASS"] = "WRONG_PASSWRD"