Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #17039 to 8.18: Fix logstash-keystore to accept spaces in values when added via stdin #17040

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 7, 2025

Backport PR #17039 to 8.18 branch, original message:


Release notes

Fix logstash-keystore to accept spaces in values when added via stdin

What does this PR do?

logstash-keystore incorrectly handled values containing spaces, causing only the first word to be stored.
For example, a value like "Hello, world!" was split, resulting in "Hello," as the stored value instead of the full string.
This commit preserves spaces in values, ensuring that multi-word strings are stored as intended.

Why is it important/What is the impact to the user?

This issue mainly affected ECK users who followed best practices for managing secure settings, leading to incorrect value assignments.

apiVersion: v1
kind: Secret
metadata:
  name: logstash-secure-settings
  namespace: logstash-sample
stringData:
  hello: "Hello, world!"
  bye: "bye"

Users who use stdin to add value are impacted as well. For example, echo "somevalue" | bin/logstash-keystore add hello

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

echo "hello world" | bin/logstash-keystore add hello
bin/logstash -e "input{ generator{ count => 1 tags => ['${hello}'] }}"

it should print "hello world"

Related issues

Use cases

Screenshots

Logs

…#17039)

This commit preserves spaces in values, ensuring that multi-word strings are stored as intended.
Prior to this change, `logstash-keystore` incorrectly handled values containing spaces,
causing only the first word to be stored.

(cherry picked from commit 5573b5a)
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisecheng kaisecheng merged commit 08439f8 into 8.18 Feb 7, 2025
1 of 3 checks passed
@kaisecheng kaisecheng deleted the backport_17039_8.18 branch February 7, 2025 21:33
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants