feat: allow providing properties (such as unpack
) in ordering
input file
#350
+113
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 for fixing electron/universal#117
This implementation achieves proposal
2b
Excerpt below:
In allowing more explicit control within the ordering file, advanced usage of electron/asar is provided (and kind of needed for electron/universal's current auto-unpack logic) to bypass limitations of the
minimatch
packageRight now, the "ordering" file is simply of format:
Right now,
electron/asar
only pulls the filename value before the:
asar/src/asar.ts
Lines 92 to 95 in 121efeb
This proposal is to leverage
<anything>
to beJSON.stringify
of Type:Notes:
--ordering
property, just extracted to a separate functionordering
file sets for any test that wants to leverage it.