Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Prettier + husky + lint-staged #1792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add Prettier + husky + lint-staged #1792

wants to merge 1 commit into from

Conversation

erickzhao
Copy link
Member

Should be a no-op for users, but sets us up for a proper linting setup in the future.

  • Adds caching for ESLint
  • Adds Prettier for formatting (removes all previous ESLint rules)
  • Adds Husky and lint-staged for pre-commit hook validation

@erickzhao erickzhao marked this pull request as ready for review February 7, 2025 18:31
@erickzhao erickzhao requested a review from a team as a code owner February 7, 2025 18:31
dsanders11
dsanders11 reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as here regarding using prettier on the GHA workflows.

@erickzhao erickzhao force-pushed the prettier-husky-lint-staged branch from ec8561f to 81aba4e Compare February 8, 2025 02:32
@erickzhao erickzhao requested a review from dsanders11 February 8, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 Awaiting requested review from dsanders11

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erickzhao @dsanders11