-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Gtk4 #2082
Draft
jeremypw
wants to merge
458
commits into
master
Choose a base branch
from
gtk4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Port to Gtk4 #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2023
Closed
Leaving open to aid incorporating changes into new development focus |
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1941
Fixes #2033
Fixes #631
Very much a work in progress but pushing for visibility.
Complicated chains of signals are replaced where possible with actions on the main window and its main children, which can be activated directly by child widgets. Where possible classes are merged and abstract classes replaced by interfaces.Convenience functions and properties are maintained only if much used.
The initial aim is to produce the simplest possible code (using best features of Gtk4) that produces an acceptably similar UX to the current master. Animations and extreme corner cases are left for now.
In the interest of simpler code and not supporting both dynamic lists and TreeModel/CellRenderers the List View only supports a single level (using Gtk.ColumnView). We already have a horizontally expandable view in Files.ColumnView. It may be possible to reimplement expandable rows with a TreeListModel at a later date.