Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Host name #229

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use Host name #229

wants to merge 1 commit into from

Conversation

danirabbit
Copy link
Member

Make things more personal by using your device's name instead of "this device":

Screenshot from 2024-06-03 12 10 28

@danirabbit danirabbit requested a review from a team June 3, 2024 19:15
@danirabbit danirabbit marked this pull request as draft June 3, 2024 19:44
@danirabbit
Copy link
Member Author

Turns out this uses the static hostname. Not sure if there's a way to get pretty name without creating a whole dbus

@danirabbit danirabbit removed the request for review from a team June 3, 2024 19:46
Copy link
Contributor

@TomiOhl TomiOhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: could be trouble to translate this to Hungarian: it would sound very unnatural to write this without a definite article. The problem is, in Hungarian there are two definite articles & their usage depends on the first letter of the word after it (in this case, the host name) - before a consonant it's "a", before a vowel it's "az". A common but ugly way to write it is "a(z)", another suboptimal way is to write "the following: <hostname>".
Not meaning to criticize the changes, there is a bunch of occurences of strings in any software that require the above (or even worse) workarounds, just thought I would share a quick fyi that you might consider anytime you need to write a copy 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants