Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StyleView: Draw desktop previews with Gtk.Picture and Gtk.CSS #236

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

StyleView: Draw desktop previews with Gtk.Picture and Gtk.CSS #236

wants to merge 3 commits into from

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 14, 2024 •
edited
Loading

AFTER

Screenshot from 2024-07-14 14 01 00

BEFORE

Screenshot from 2024-07-14 14 22 46

Draw background with Gtk.Picture and Draw shell and windows with CSS

  • Matches display aspect ratio
  • loads faster
  • Respects background dim setting

@danirabbit danirabbit requested a review from a team July 14, 2024 21:08
zeebok
zeebok requested changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good here but need to fix conflicts

@danirabbit danirabbit marked this pull request as draft August 18, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok