Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve follow group notification inspired by Bluesky UI #3151

Merged
merged 9 commits into from
Jan 24, 2025

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Jan 24, 2025

resolve #908

Screenshots

Widescreen

1 follower

screenshot of notification page, 1 follower is shown with avatar and display name

8 followers

screenshot of notification page, 5 avatars and "+3" label is shown with icon

8 followers (expanded)

screenshot of notification page, many avatars with names listed with top hide label

Mobile

1 follower

screenshot of notification page similar to widescreen

8 followers

screenshot of notification page similar to widescreen

8 followers (expanded)

screenshot of notification page similar to widescreen

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit ec948f1
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/679397b9fc1845000877ffce

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit ec948f1
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/679397b99362a5000925d51b
😎 Deploy Preview https://deploy-preview-3151--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3 shuuji3 marked this pull request as draft January 24, 2025 05:31
@shuuji3 shuuji3 changed the title [WIP] feat: bluesky-style follow notification feat: bluesky-style follow notification Jan 24, 2025
@shuuji3 shuuji3 force-pushed the shuuji3/feat/bluesky-style-notification-expand branch from 9f8d52a to 82cd947 Compare January 24, 2025 06:40
@Shinigami92 Shinigami92 self-requested a review January 24, 2025 07:03
@shuuji3 shuuji3 marked this pull request as ready for review January 24, 2025 13:34
@shuuji3
Copy link
Member Author

shuuji3 commented Jan 24, 2025

It's ready to review and I updated the screenshots. To test large follow count, you can use a filter to show only follow notifications.

screenshot of notification page with 29 follows, "status" menu item is selected in filter

@shuuji3
Copy link
Member Author

shuuji3 commented Jan 24, 2025

Thanks for the review!

@shuuji3 shuuji3 added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit a7d64fd Jan 24, 2025
16 checks passed
@shuuji3 shuuji3 deleted the shuuji3/feat/bluesky-style-notification-expand branch January 24, 2025 15:24
@shuuji3 shuuji3 changed the title feat: bluesky-style follow notification feat: improve follow group notification inspired by Bluesky UI Jan 27, 2025
Cl0v1s pushed a commit to BDX-town/elk that referenced this pull request Jan 27, 2025
Cl0v1s pushed a commit to BDX-town/elk that referenced this pull request Jan 30, 2025
ayoayco pushed a commit that referenced this pull request Feb 6, 2025
ayoayco pushed a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show name of who follows you
2 participants