Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: can set an observer that gets notified on renewals and relinquishments #14

Merged
merged 7 commits into from
Feb 16, 2025
Merged

feat: can set an observer that gets notified on renewals and relinquishments #14

merged 7 commits into from
Feb 16, 2025
+187 −14

Conversation

hiddentao
Copy link
Contributor

No description provided.

@hiddentao
Copy link
Contributor Author

@Arachnid Wasn't sure about the desired approach here so went with what I felt made sense for now. Will add tests if all is good.

@coveralls
Copy link

coveralls commented Feb 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13351821897

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.8%) to 57.967%
Totals Coverage Status
Change from base Build 13259132306: 3.8%
Covered Lines: 193
Relevant Lines: 324
💛 - Coveralls

Arachnid
Arachnid requested changes Feb 10, 2025
View reviewed changes
contracts/src/registry/ETHRegistry.sol Outdated Show resolved Hide resolved
contracts/src/registry/ETHRegistry.sol Outdated Show resolved Hide resolved
@Arachnid
Copy link
Member

BET-240

@hiddentao hiddentao requested a review from Arachnid February 11, 2025 01:14
Arachnid
Arachnid requested changes Feb 11, 2025
View reviewed changes
contracts/src/registry/ETHRegistry.sol Outdated Show resolved Hide resolved
@hiddentao hiddentao changed the title feat: admin can set a renewals observer that gets notified on renewals [WIP] feat: can set a renewals observer that gets notified on renewals Feb 11, 2025
@hiddentao hiddentao changed the title feat: can set a renewals observer that gets notified on renewals feat: can set an observer that gets notified on renewals and relinquishments Feb 11, 2025
@hiddentao hiddentao requested a review from Arachnid February 11, 2025 11:02
Arachnid
Arachnid approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@Arachnid Arachnid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix, otherwise lgtm.

contracts/src/registry/ETHRegistry.sol Show resolved Hide resolved
@hiddentao hiddentao marked this pull request as ready for review February 16, 2025 04:45
@hiddentao hiddentao merged commit 3d1d135 into main Feb 16, 2025
1 check passed
@hiddentao hiddentao deleted the feature/bet-240-implement-renewal-hook-support-so-that-ejection-authorities branch February 16, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arachnid Arachnid Arachnid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiddentao @coveralls @Arachnid