Skip to content

Commit

Permalink
fix(github-ci): upgrade actions/upload-artifact@v3 to v4 (#6488)
Browse files Browse the repository at this point in the history
* fix(github-ci): upgrade actions/upload-artifact@v3 to v4

* just trigger github ci

* fix(github-ci): upgrade actions/download-artifact@v3 to v4
  • Loading branch information
sfwn authored Feb 7, 2025
1 parent 6fea8ae commit 51aeca4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/ci-it.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
run: |
HOME=/root make proto-go-in-local
- name: Upload proto-go As Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: proto-go
path: ./api/proto-go
Expand All @@ -77,7 +77,7 @@ jobs:
with:
fetch-depth: 0
- name: Fetch proto-go
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: proto-go
path: ./api/proto-go
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
with:
fetch-depth: 0
- name: Fetch proto-go
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: proto-go
path: ./api/proto-go
Expand Down Expand Up @@ -171,7 +171,7 @@ jobs:
with:
fetch-depth: 0
- name: Fetch proto-go
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: proto-go
path: ./api/proto-go
Expand Down Expand Up @@ -206,7 +206,7 @@ jobs:
mkdir -p ./coverage
go test -work -timeout=10s -failfast -race -cover -coverprofile=./coverage/${{ steps.cov-report-name.outputs.path }} -covermode=atomic -gcflags='-l -N' ${{ matrix.package-paths }}
- name: Upload coverage As Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.cov-report-name.outputs.name }}
path: ./coverage/${{ steps.cov-report-name.outputs.path }}
Expand All @@ -222,7 +222,7 @@ jobs:
with:
fetch-depth: 0
- name: Download coverage reports
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: ./coverage/
- name: Handle coverage reports
Expand All @@ -237,7 +237,7 @@ jobs:
fail_ci_if_error: true
flags: by-github-actions
- name: Upload combined coverage reports to artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pure-coverage
path: ./coverage/
Expand Down
3 changes: 2 additions & 1 deletion internal/apps/ai-proxy/filters/azure-director/filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package azure_director
import (
"context"
"encoding/json"
"fmt"
"io"
"net/http"
"net/url"
Expand Down Expand Up @@ -262,7 +263,7 @@ func (f *AzureDirector) RewritePath(ctx context.Context) error {

rewrite, err := strconv.Unquote(f.processorArgs["RewritePath"])
if err != nil {
return errors.Errorf("failed to get RewritePath args, err: %v", err)
return fmt.Errorf("failed to get RewritePath args, err: %v", err)
}
if rewrite == "" {
return nil
Expand Down

0 comments on commit 51aeca4

Please sign in to comment.