Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated graphiql to v3 #4474

Conversation

xvnds
Copy link
Contributor

@xvnds xvnds commented Jan 28, 2025

Current implemented GraphiQL version in this repo still uses React UMD build. This caused the IDE to be stuck at "Loading" since React 19 doesn't have UMD builds anymore: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#umd-builds-removed

Updated GraphiQL to v3 so it uses the latest tech stack.

Reference: https://github.com/graphql/graphiql/tree/main/examples/graphiql-cdn

@chrzaszcz
Copy link
Member

Thanks for the contribution! I confirm that the issue is present. We will test the PR, and see if it can be merged.

@DenysGonchar DenysGonchar changed the base branch from master to graphql-cleanup February 6, 2025 10:08
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution.

@DenysGonchar DenysGonchar merged commit b415018 into esl:graphql-cleanup Feb 6, 2025
@jacekwegr jacekwegr added this to the 6.3.2 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants