Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[speaker] Media Player Components Docs PR3 #4630

Open
wants to merge 12 commits into
base: next
Choose a base branch
from

Conversation

kahrendt
Copy link
Contributor

@kahrendt kahrendt commented Jan 31, 2025

Description:

This is documentation pull request 3 of 3 for adding new speaker media player components with several other helper components. It is built off #4629.

PR3 adds documentation for the speaker media player.

Related issue (if applicable): not applicable

Pull request in esphome with YAML changes (if applicable): esphome/esphome#8171

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

@probot-esphome probot-esphome bot added the next label Jan 31, 2025
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 42163a2
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/67a3d407a4b5710008e83260
😎 Deploy Preview https://deploy-preview-4630--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kahrendt kahrendt force-pushed the speaker-media-player branch from d549e24 to 61d2962 Compare January 31, 2025 17:29
@kahrendt kahrendt marked this pull request as ready for review January 31, 2025 19:01
@kahrendt kahrendt force-pushed the speaker-media-player branch from 61d2962 to 46f33e7 Compare February 4, 2025 20:30
Copy link
Contributor

@nielsnl68 nielsnl68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo fixed

:description: Instructions for setting up mixer speakers in ESPHome.
:image: mixer.svg

The ``mixer`` speaker platform allows you to mix audio sent to different source speakers into one output which is sent to another :doc:`speaker component </components/speaker/index>`. Individual source speakers may be ducked (made quieter) with the :ref:`apply ducking action <mixer_speaker-apply_ducking>`.
Copy link
Contributor

@nielsnl68 nielsnl68 Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The ``mixer`` speaker platform allows you to mix audio sent to different source speakers into one output which is sent to another :doc:`speaker component </components/speaker/index>`. Individual source speakers may be ducked (made quieter) with the :ref:`apply ducking action <mixer_speaker-apply_ducking>`.
The ``mixer`` speaker platform allows you to mix audio sent from different source speakers into one output which is sent to another :doc:`speaker component </components/speaker/index>`. Individual source speakers may be ducked (made quieter) with the :ref:`apply ducking action <mixer_speaker-apply_ducking>`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mixer component adds the source speakers itself (add them under the source_speakers parameter as a list. So other audio components (rtttl, media player) need to send audio to these virtual source speakers. So I think this is the correct word here, as other components will send it to this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants