-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packet_transport] Extract packet encoding functionality #8187
Open
clydebarrow
wants to merge
34
commits into
esphome:dev
Choose a base branch
from
clydebarrow:packet-encoding
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8187 +/- ##
==========================================
+ Coverage 53.70% 53.81% +0.10%
==========================================
Files 50 50
Lines 9408 9856 +448
Branches 1654 1360 -294
==========================================
+ Hits 5053 5304 +251
- Misses 4056 4230 +174
- Partials 299 322 +23 ☔ View full report in Codecov by Sentry. |
probot-esphome
bot
added
integration: packet_transport
and removed
integration: packet_encoding
labels
Feb 4, 2025
Add tests
3 tasks
clydebarrow
changed the title
[packet_encoding] Extract packet encoding functionality
[packet_transport] Extract packet encoding functionality
Feb 5, 2025
clydebarrow
commented
Feb 5, 2025
Testing... |
15 tasks
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The packet encoding routines in the
udp
component have been hoisted out into a dedicated, transport-independent, platform component that can be used by multiple communication mechanisms.The
packet_transport
component provides all sensor encode/decode, encryption etc. The UDP component just provides the send/receive functionality.the
udp.sensor
andudp.binary_sensor
components are nowpacket_transport.sensor
andpacket_transport.binary_sensor
.UDP component also now has a receive trigger and write action.
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: